Revert "UPSTREAM: mm: page_alloc: set migratetype inside move_freepages()"
This reverts commit a0fe7bbc01
.
Change-Id: I50d549431103874a2db923713948061b1a1a9cbb
Bug: 420771453
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
This commit is contained in:
@@ -1787,8 +1787,9 @@ static inline struct page *__rmqueue_cma_fallback(struct zone *zone,
|
||||
#endif
|
||||
|
||||
/*
|
||||
* Change the type of a block and move all its free pages to that
|
||||
* type's freelist.
|
||||
* Move the free pages in a range to the freelist tail of the requested type.
|
||||
* Note that start_page and end_pages are not aligned on a pageblock
|
||||
* boundary. If alignment is required, use move_freepages_block()
|
||||
*/
|
||||
static int move_freepages(struct zone *zone, unsigned long start_pfn,
|
||||
unsigned long end_pfn, int migratetype)
|
||||
@@ -1798,9 +1799,6 @@ static int move_freepages(struct zone *zone, unsigned long start_pfn,
|
||||
unsigned int order;
|
||||
int pages_moved = 0;
|
||||
|
||||
VM_WARN_ON(start_pfn & (pageblock_nr_pages - 1));
|
||||
VM_WARN_ON(start_pfn + pageblock_nr_pages - 1 != end_pfn);
|
||||
|
||||
for (pfn = start_pfn; pfn <= end_pfn;) {
|
||||
page = pfn_to_page(pfn);
|
||||
if (!PageBuddy(page)) {
|
||||
@@ -1818,8 +1816,6 @@ static int move_freepages(struct zone *zone, unsigned long start_pfn,
|
||||
pages_moved += 1 << order;
|
||||
}
|
||||
|
||||
set_pageblock_migratetype(pfn_to_page(start_pfn), migratetype);
|
||||
|
||||
return pages_moved;
|
||||
}
|
||||
|
||||
@@ -2047,6 +2043,7 @@ steal_suitable_fallback(struct zone *zone, struct page *page,
|
||||
if (free_pages + alike_pages >= (1 << (pageblock_order-1)) ||
|
||||
page_group_by_mobility_disabled) {
|
||||
move_freepages(zone, start_pfn, end_pfn, start_type);
|
||||
set_pageblock_migratetype(page, start_type);
|
||||
return __rmqueue_smallest(zone, order, start_type);
|
||||
}
|
||||
|
||||
@@ -2124,10 +2121,12 @@ static void reserve_highatomic_pageblock(struct page *page, struct zone *zone)
|
||||
/* Yoink! */
|
||||
mt = get_pageblock_migratetype(page);
|
||||
/* Only reserve normal pageblocks (i.e., they can merge with others) */
|
||||
if (migratetype_is_mergeable(mt))
|
||||
if (move_freepages_block(zone, page,
|
||||
MIGRATE_HIGHATOMIC) != -1)
|
||||
if (migratetype_is_mergeable(mt)) {
|
||||
if (move_freepages_block(zone, page, MIGRATE_HIGHATOMIC) != -1) {
|
||||
set_pageblock_migratetype(page, MIGRATE_HIGHATOMIC);
|
||||
zone->nr_reserved_highatomic += pageblock_nr_pages;
|
||||
}
|
||||
}
|
||||
|
||||
out_unlock:
|
||||
spin_unlock_irqrestore(&zone->lock, flags);
|
||||
@@ -2212,6 +2211,7 @@ static bool unreserve_highatomic_pageblock(const struct alloc_context *ac,
|
||||
* not fail on zone boundaries.
|
||||
*/
|
||||
WARN_ON_ONCE(ret == -1);
|
||||
set_pageblock_migratetype(page, ac->migratetype);
|
||||
if (ret > 0) {
|
||||
spin_unlock_irqrestore(&zone->lock, flags);
|
||||
return ret;
|
||||
@@ -2842,9 +2842,10 @@ int __isolate_free_page(struct page *page, unsigned int order)
|
||||
* Only change normal pageblocks (i.e., they can merge
|
||||
* with others)
|
||||
*/
|
||||
if (migratetype_is_mergeable(mt))
|
||||
move_freepages_block(zone, page,
|
||||
MIGRATE_MOVABLE);
|
||||
if (migratetype_is_mergeable(mt) &&
|
||||
move_freepages_block(zone, page,
|
||||
MIGRATE_MOVABLE) != -1)
|
||||
set_pageblock_migratetype(page, MIGRATE_MOVABLE);
|
||||
}
|
||||
}
|
||||
|
||||
|
@@ -189,6 +189,7 @@ static int set_migratetype_isolate(struct page *page, int migratetype, int isol_
|
||||
return -EBUSY;
|
||||
}
|
||||
__mod_zone_freepage_state(zone, -nr_pages, mt);
|
||||
set_pageblock_migratetype(page, MIGRATE_ISOLATE);
|
||||
zone->nr_isolate_pageblock++;
|
||||
spin_unlock_irqrestore(&zone->lock, flags);
|
||||
return 0;
|
||||
@@ -262,10 +263,10 @@ static void unset_migratetype_isolate(struct page *page, int migratetype)
|
||||
*/
|
||||
WARN_ON_ONCE(nr_pages == -1);
|
||||
__mod_zone_freepage_state(zone, nr_pages, migratetype);
|
||||
} else {
|
||||
set_pageblock_migratetype(page, migratetype);
|
||||
__putback_isolated_page(page, order, migratetype);
|
||||
}
|
||||
set_pageblock_migratetype(page, migratetype);
|
||||
if (isolated_page)
|
||||
__putback_isolated_page(page, order, migratetype);
|
||||
zone->nr_isolate_pageblock--;
|
||||
out:
|
||||
spin_unlock_irqrestore(&zone->lock, flags);
|
||||
|
Reference in New Issue
Block a user