Guenter Roeck 866cf12a0e
hwmon: (pmbus) Don't return errors from driver remove functions ...
Driver remove functions have an error return value, but rarely return an error
in practice. If a driver does return an error from its remove function, the
driver won't be unloaded and is expected to stay alive.
pmbus_do_remove() is defined as returning an int, but always returns 0 (no
error). Calling code passes that return value on to high level driver
remove functions, but does not evaluate it and removes driver data even if
pmbus_do_remove() returned an error (which it in practice never does). Even if
this code could never cause a real problem, it is nevertheless conceptually
wrong.
To reduce confusion and simplify the code, change pmbus_do_remove() to be a void
function, and have PMBus client drivers always return zero in their driver
remove functions.
Reported-by: Jean Delvare <khali@linux-fr.org >
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com >
Acked-by: Jean Delvare <khali@linux-fr.org >
2011-10-24 11:09:33 -07:00
2011-10-24 11:09:33 -07:00
2011-05-25 20:43:33 +02:00
2011-05-25 20:43:33 +02:00
2011-05-25 20:43:32 +02:00
2011-02-26 08:59:32 -08:00
2010-03-30 22:02:32 +09:00
2011-05-25 20:43:31 +02:00
2009-12-14 21:17:27 +01:00
2010-10-18 11:03:14 +02:00
2011-03-31 11:26:23 -03:00
2009-12-14 21:17:26 +01:00
2010-09-17 17:24:14 +02:00
2011-01-12 21:55:09 +01:00
2011-03-21 17:59:37 +01:00
2011-01-12 21:55:08 +01:00
2010-08-25 15:42:10 +02:00
2011-02-26 08:59:32 -08:00
2010-03-30 22:02:32 +09:00
2011-01-08 10:55:02 -08:00
2010-10-28 20:31:50 +02:00
2010-11-15 21:38:56 +01:00
2011-01-23 09:28:50 -08:00
2011-01-08 10:55:03 -08:00
2010-10-28 20:31:50 +02:00
2011-07-17 18:39:18 +02:00
2010-03-30 22:02:32 +09:00
2011-09-28 08:19:21 -07:00
2011-01-12 21:55:13 +01:00
2011-09-21 17:25:18 -07:00
2009-12-14 21:17:26 +01:00
2011-07-03 13:32:53 +02:00
2011-02-09 13:45:52 -08:00
2010-08-14 21:08:54 +02:00
2011-01-08 10:55:07 -08:00
2011-07-03 13:32:53 +02:00
2010-10-24 13:41:39 -07:00
2011-05-25 20:43:31 +02:00
2011-01-12 21:55:11 +01:00
2010-10-18 11:03:14 +02:00
2009-12-14 21:17:27 +01:00
2011-07-21 14:10:00 +02:00
2011-03-29 14:48:19 +02:00
2011-07-25 21:46:10 +02:00
2011-01-08 10:55:11 -08:00
2011-08-23 21:04:28 -07:00
2011-08-11 10:14:18 -07:00
2011-06-17 23:22:27 -07:00
2011-07-25 21:46:10 +02:00
2011-05-25 20:43:32 +02:00
2011-03-23 10:42:02 +01:00
2011-05-25 20:43:31 +02:00
2011-05-25 20:43:31 +02:00
2011-07-30 08:57:57 -10:00
2011-03-16 06:57:34 -07:00
2011-02-09 13:45:42 -08:00
2011-05-25 20:43:31 +02:00
2010-06-03 11:33:58 +02:00
2011-03-21 17:59:36 +01:00
2010-08-14 21:08:50 +02:00
2009-12-14 21:17:26 +01:00
2011-07-25 21:46:11 +02:00
2009-12-14 21:17:26 +01:00
2009-12-14 21:17:27 +01:00
2011-04-29 16:33:36 +02:00
2009-12-14 21:17:27 +01:00
2011-07-28 20:16:36 -07:00
2009-12-14 21:17:26 +01:00
2011-01-18 12:22:54 -08:00
2011-07-28 00:17:35 -07:00
2011-07-28 00:17:35 -07:00
2011-03-14 22:39:11 -07:00
2010-12-13 09:54:50 -08:00
2010-08-14 21:08:49 +02:00
2010-11-05 10:17:19 -07:00
2011-07-30 08:57:57 -10:00
2011-07-25 21:46:10 +02:00
2009-12-14 21:17:26 +01:00
2011-07-28 00:17:33 -07:00
2011-03-14 22:36:25 -07:00
2011-06-04 10:34:28 -07:00
2011-05-25 20:43:32 +02:00
2011-09-06 08:56:06 -07:00
2010-08-12 11:28:03 +02:00
2011-08-22 14:04:05 -07:00
2011-01-12 21:55:11 +01:00
2011-01-12 21:55:11 +01:00
2011-01-08 10:55:16 -08:00
2011-06-17 23:22:27 -07:00
2011-07-25 21:46:09 +02:00
2011-07-25 21:46:09 +02:00
2011-07-25 21:46:09 +02:00
2011-07-25 21:46:09 +02:00
2011-07-26 16:49:47 -07:00
2011-01-08 10:56:28 -08:00
2011-01-08 10:55:18 -08:00
2010-08-09 20:45:10 -07:00
2011-01-08 10:55:19 -08:00
2011-01-08 10:55:27 -08:00
2009-12-14 21:17:26 +01:00
2009-12-14 21:17:27 +01:00
2011-03-31 11:26:23 -03:00
2010-05-27 19:58:49 +02:00
2010-10-28 20:31:50 +02:00
2011-05-01 09:06:35 -07:00
2011-05-25 20:43:31 +02:00
2011-01-12 21:55:09 +01:00
2011-07-25 21:46:10 +02:00
2011-01-08 10:55:30 -08:00
2011-01-08 10:55:31 -08:00
2009-12-14 21:17:26 +01:00
2009-12-14 21:17:26 +01:00
2011-10-24 11:09:32 -07:00
2011-01-08 10:55:33 -08:00
2011-01-12 21:55:11 +01:00
2011-09-21 17:25:18 -07:00
2011-03-31 11:26:23 -03:00
2011-03-31 11:26:23 -03:00
2011-01-12 21:55:09 +01:00
2010-03-30 22:02:32 +09:00
2009-09-17 09:46:51 +02:00
866cf12a0e