David Howells 112fc894a7
configfs: Fix potential NULL d_inode dereference ...
Code that does this:
if (!(d_unhashed(dentry) && dentry->d_inode)) {
...
simple_unlink(parent->d_inode, dentry);
}
is broken because:
!(d_unhashed(dentry) && dentry->d_inode)
is equivalent to:
!d_unhashed(dentry) || !dentry->d_inode
so it is possible to get into simple_unlink() with dentry->d_inode == NULL.
simple_unlink(), however, assumes dentry->d_inode cannot be NULL.
I think that what was meant is this:
!d_unhashed(dentry) && dentry->d_inode
and that the logical-not operator or the final close-bracket was misplaced.
Signed-off-by: David Howells <dhowells@redhat.com >
cc: Joel Becker <joel.becker@oracle.com >
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2015-02-20 04:56:43 -05:00
2015-02-12 13:50:21 -08:00
2015-02-17 14:34:53 -08:00
2015-02-12 13:50:21 -08:00
2014-11-19 13:01:20 -05:00
2015-02-17 14:34:50 -08:00
2015-02-12 13:50:21 -08:00
2014-11-19 13:01:20 -05:00
2015-02-12 13:50:21 -08:00
2015-02-12 13:50:21 -08:00
2015-02-17 14:34:50 -08:00
2015-02-20 04:56:43 -05:00
2015-02-17 12:21:51 -05:00
2015-01-18 01:03:45 -05:00
2015-01-20 14:03:05 -07:00
2015-01-29 19:16:40 +01:00
2015-02-16 17:56:03 -08:00
2014-11-03 15:20:29 -05:00
2015-02-16 17:56:04 -08:00
2015-01-05 11:13:55 +01:00
2015-02-17 16:12:34 -08:00
2015-02-12 19:28:50 -08:00
2015-02-17 14:34:51 -08:00
2014-10-13 17:52:21 +01:00
2015-02-12 13:50:21 -08:00
2015-02-17 16:12:34 -08:00
2014-12-10 17:41:16 -08:00
2014-12-18 19:08:10 -08:00
2014-10-31 17:48:54 -04:00
2015-01-20 14:03:05 -07:00
2015-01-07 09:51:49 +01:00
2014-11-18 10:15:29 +01:00
2014-12-12 09:28:03 -08:00
2014-11-28 18:23:44 -08:00
2015-02-17 16:12:34 -08:00
2015-02-13 21:21:36 -08:00
2015-02-12 10:39:41 -08:00
2015-02-17 14:56:45 -08:00
2015-02-12 13:50:21 -08:00
2015-02-16 11:43:13 -05:00
2015-02-12 13:50:21 -08:00
2015-02-10 14:30:28 -08:00
2015-01-20 14:03:04 -07:00
2015-02-16 17:56:05 -08:00
2014-10-14 02:18:22 +02:00
2014-12-08 20:39:29 -05:00
2015-02-17 14:56:45 -08:00
2015-01-16 16:01:29 -08:00
2015-02-10 15:52:38 -08:00
2015-01-20 14:03:05 -07:00
2015-02-17 14:34:51 -08:00
2015-01-20 14:03:05 -07:00
2014-11-27 18:48:44 +00:00
2015-02-15 11:11:47 -08:00
2015-02-15 10:11:39 -08:00
2015-02-05 16:34:25 +01:00
2015-02-17 14:34:51 -08:00
2015-02-12 18:54:28 -08:00
2015-02-12 13:50:21 -08:00
2015-02-20 04:03:58 -05:00
2014-11-19 13:01:20 -05:00
2014-10-09 02:39:00 -04:00
2014-12-11 17:56:37 -08:00
2014-12-13 12:42:51 -08:00
2014-12-17 08:27:14 -05:00
2014-12-13 12:42:51 -08:00
2015-02-12 14:13:23 -08:00
2014-10-21 13:55:11 -06:00
2015-01-20 14:02:58 -07:00
2014-10-31 17:48:54 -04:00
2014-10-14 02:18:21 +02:00
2015-02-16 17:56:04 -08:00
2015-02-17 14:56:45 -08:00
2014-09-26 21:16:51 -04:00
2015-02-12 18:54:09 -08:00
2015-02-17 14:34:52 -08:00
2015-02-13 21:21:40 -08:00
2015-01-23 00:22:20 -05:00
2015-01-08 15:10:52 -08:00
2014-10-13 11:28:42 +02:00
2014-12-10 17:41:10 -08:00
2015-01-25 23:17:29 -05:00
2015-02-17 16:12:34 -08:00
2015-02-17 16:12:34 -08:00
2015-02-17 14:56:45 -08:00
2015-02-10 14:30:30 -08:00
2015-02-16 17:56:04 -08:00
2015-02-17 16:29:36 +01:00
2015-02-05 02:45:00 -05:00
2015-02-02 18:09:38 +01:00
2015-02-17 14:25:58 -08:00
2015-01-25 23:17:29 -05:00
2014-10-09 22:25:53 -04:00
2015-01-23 00:23:58 -05:00
2015-02-17 14:56:45 -08:00
2014-12-10 21:30:20 -05:00
2015-02-17 15:27:47 -08:00
2014-12-02 10:46:50 -06:00
2015-02-05 02:45:00 -05:00
2015-02-17 15:48:33 -08:00
2014-10-31 17:48:54 -04:00
2015-02-12 18:54:12 -08:00
2015-02-13 21:21:39 -08:00
2014-11-05 14:13:23 -05:00
2015-01-29 00:13:13 -05:00
2015-02-17 14:56:45 -08:00
2015-02-05 02:45:00 -05:00
2014-11-05 14:13:23 -05:00
2014-11-19 13:01:26 -05:00
112fc894a7