samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: v4l: Memset argument to 0 before calling get_mbus_config pad op

Browse Source 
[ Upstream commit 91d6a99acfa5ce9f95ede775074b80f7193bd717 ]

Memset the config argument to get_mbus_config V4L2 sub-device pad
operation to zero before calling the operation. This ensures the callers
don't need to bother with it nor the implementations need to set all
fields that may not be relevant to them.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Sakari Ailus
2024-12-16 10:48:49 +02:00
committed by Greg Kroah-Hartman
parent 0b9d2468c3
commit f8a9f45f75
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/v4l2-core/v4l2-subdev.c
View File

@@ -351,6 +351,8 @@ static int call_enum_dv_timings(struct v4l2_subdev *sd,
static int call_get_mbus_config(struct v4l2_subdev *sd, unsigned int pad, static int call_get_mbus_config(struct v4l2_subdev *sd, unsigned int pad,
struct v4l2_mbus_config *config) struct v4l2_mbus_config *config)
{ {
memset(config, 0, sizeof(*config));
return check_pad(sd, pad) ? : return check_pad(sd, pad) ? :
sd->ops->pad->get_mbus_config(sd, pad, config); sd->ops->pad->get_mbus_config(sd, pad, config);
} }

4
include/media/v4l2-subdev.h
View File

@@ -822,7 +822,9 @@ struct v4l2_subdev_state {
* possible configuration from the remote end, likely calling * possible configuration from the remote end, likely calling
* this operation as close as possible to stream on time. The * this operation as close as possible to stream on time. The
* operation shall fail if the pad index it has been called on * operation shall fail if the pad index it has been called on
* is not valid or in case of unrecoverable failures. * is not valid or in case of unrecoverable failures. The
* config argument has been memset to 0 just before calling
* the op.
* *
* @set_routing: enable or disable data connection routes described in the * @set_routing: enable or disable data connection routes described in the
* subdevice routing table. * subdevice routing table.