remoteproc: qcom_wcnss_iris: Add missing put_device() on error in probe
[ Upstream commit 0cb4b1b97041d8a1f773425208ded253c1cb5869 ]
The device_del() call matches with the device_add() but we also need
to call put_device() to trigger the qcom_iris_release().
Fixes: 1fcef985c8
("remoteproc: qcom: wcnss: Fix race with iris probe")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/4604f7e0-3217-4095-b28a-3ff8b5afad3a@stanley.mountain
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
41581d392c
commit
f1a3c8ceb2
@@ -197,6 +197,7 @@ struct qcom_iris *qcom_iris_probe(struct device *parent, bool *use_48mhz_xo)
|
||||
|
||||
err_device_del:
|
||||
device_del(&iris->dev);
|
||||
put_device(&iris->dev);
|
||||
|
||||
return ERR_PTR(ret);
|
||||
}
|
||||
@@ -204,4 +205,5 @@ err_device_del:
|
||||
void qcom_iris_remove(struct qcom_iris *iris)
|
||||
{
|
||||
device_del(&iris->dev);
|
||||
put_device(&iris->dev);
|
||||
}
|
||||
|
Reference in New Issue
Block a user