samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: qedf: Use designated initializer for struct qed_fcoe_cb_ops

Browse Source 
[ Upstream commit d8720235d5b5cad86c1f07f65117ef2a96f8bec7 ]

Recent fixes to the randstruct GCC plugin allowed it to notice
that this structure is entirely function pointers and is therefore
subject to randomization, but doing so requires that it always use
designated initializers. Explicitly specify the "common" member as being
initialized. Silences:

drivers/scsi/qedf/qedf_main.c:702:9: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
  702 |         {
      |         ^

Fixes: 035f7f87b7 ("randstruct: Enable Clang support")
Link: https://lore.kernel.org/r/20250502224156.work.617-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Kees Cook
2025-05-02 15:41:57 -07:00
committed by Greg Kroah-Hartman
parent e500dff1e4
commit ee96502062
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/qedf/qedf_main.c
View File

@@ -699,7 +699,7 @@ static u32 qedf_get_login_failures(void *cookie)
} }
static struct qed_fcoe_cb_ops qedf_cb_ops = { static struct qed_fcoe_cb_ops qedf_cb_ops = {
{ .common = {
.link_update = qedf_link_update, .link_update = qedf_link_update,
.bw_update = qedf_bw_update, .bw_update = qedf_bw_update,
.schedule_recovery_handler = qedf_schedule_recovery_handler, .schedule_recovery_handler = qedf_schedule_recovery_handler,