samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: sodaville: fix some error return code on error path

Browse Source 
Fix to return a negative error code from the error handling
case instead of 0.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Wei Yongjun
2013-12-16 13:52:04 +08:00
committed by Linus Walleij
parent ca0ae81d13
commit e6ae919590
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpio/gpio-sodaville.c
View File

@@ -176,8 +176,10 @@ static int sdv_register_irqsupport(struct sdv_gpio_chip_data *sd,
sd->id = irq_domain_add_legacy(pdev->dev.of_node, SDV_NUM_PUB_GPIOS, sd->id = irq_domain_add_legacy(pdev->dev.of_node, SDV_NUM_PUB_GPIOS,
sd->irq_base, 0, &irq_domain_sdv_ops, sd); sd->irq_base, 0, &irq_domain_sdv_ops, sd);
if (!sd->id) if (!sd->id) {
ret = -ENODEV;
goto out_free_irq; goto out_free_irq;
}
return 0; return 0;
out_free_irq: out_free_irq:
free_irq(pdev->irq, sd); free_irq(pdev->irq, sd);
@@ -212,8 +214,10 @@ static int sdv_gpio_probe(struct pci_dev *pdev,
} }
addr = pci_resource_start(pdev, GPIO_BAR); addr = pci_resource_start(pdev, GPIO_BAR);
if (!addr) if (!addr) {
ret = -ENODEV;
goto release_reg; goto release_reg;
}
sd->gpio_pub_base = ioremap(addr, pci_resource_len(pdev, GPIO_BAR)); sd->gpio_pub_base = ioremap(addr, pci_resource_len(pdev, GPIO_BAR));
prop = of_get_property(pdev->dev.of_node, "intel,muxctl", &len); prop = of_get_property(pdev->dev.of_node, "intel,muxctl", &len);