samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: ov8856: suppress probe deferral errors

Browse Source 
commit e3d86847fba58cf71f66e81b6a2515e07039ae17 upstream.

Probe deferral should not be logged as an error:

	ov8856 24-0010: failed to get HW configuration: -517

Use dev_err_probe() for the clock lookup and drop the (mostly) redundant
dev_err() from sensor probe() to suppress it.

Note that errors during regulator lookup is already correctly logged
using dev_err_probe().

Fixes: 0c2c7a1e0d ("media: ov8856: Add devicetree support")
Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold
2025-04-25 14:52:38 +02:00
committed by Greg Kroah-Hartman
parent aaf516bb73
commit ce4a5a34a2
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/media/i2c/ov8856.c
View File

@@ -2323,8 +2323,8 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, struct device *dev)
if (!is_acpi_node(fwnode)) { if (!is_acpi_node(fwnode)) {
ov8856->xvclk = devm_clk_get(dev, "xvclk"); ov8856->xvclk = devm_clk_get(dev, "xvclk");
if (IS_ERR(ov8856->xvclk)) { if (IS_ERR(ov8856->xvclk)) {
dev_err(dev, "could not get xvclk clock (%pe)\n", dev_err_probe(dev, PTR_ERR(ov8856->xvclk),
ov8856->xvclk); "could not get xvclk clock\n");
return PTR_ERR(ov8856->xvclk); return PTR_ERR(ov8856->xvclk);
} }
@@ -2429,11 +2429,8 @@ static int ov8856_probe(struct i2c_client *client)
return -ENOMEM; return -ENOMEM;
ret = ov8856_get_hwcfg(ov8856, &client->dev); ret = ov8856_get_hwcfg(ov8856, &client->dev);
if (ret) { if (ret)
dev_err(&client->dev, "failed to get HW configuration: %d",
ret);
return ret; return ret;
}
v4l2_i2c_subdev_init(&ov8856->sd, client, &ov8856_subdev_ops); v4l2_i2c_subdev_init(&ov8856->sd, client, &ov8856_subdev_ops);