samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform/x86/intel-uncore-freq: Fail module load when plat_info is NULL

Browse Source 
commit 685f88c72a0c4d12d3bd2ff50286938f14486f85 upstream.

Address a Smatch static checker warning regarding an unchecked
dereference in the function call:
set_cdie_id(i, cluster_info, plat_info)
when plat_info is NULL.

Instead of addressing this one case, in general if plat_info is NULL
then it can cause other issues. For example in a two package system it
will give warning for duplicate sysfs entry as package ID will be always
zero for both packages when creating string for attribute group name.

plat_info is derived from TPMI ID TPMI_BUS_INFO, which is integral to
the core TPMI design. Therefore, it should not be NULL on a production
platform. Consequently, the module should fail to load if plat_info is
NULL.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/platform-driver-x86/aEKvGCLd1qmX04Tc@stanley.mountain/T/#u
Fixes: 8a54e2253e ("platform/x86/intel-uncore-freq: Uncore frequency control via TPMI")
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250606205300.2384494-1-srinivas.pandruvada@linux.intel.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Srinivas Pandruvada
2025-06-06 13:53:00 -07:00
committed by Greg Kroah-Hartman
parent 2753481c40
commit c1a2081f03
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/platform/x86/intel/uncore-frequency/uncore-frequency-tpmi.c
View File

@@ -269,10 +269,13 @@ static int uncore_probe(struct auxiliary_device *auxdev, const struct auxiliary_
/* Get the package ID from the TPMI core */ /* Get the package ID from the TPMI core */
plat_info = tpmi_get_platform_data(auxdev); plat_info = tpmi_get_platform_data(auxdev);
if (plat_info) if (unlikely(!plat_info)) {
pkg = plat_info->package_id;
else
dev_info(&auxdev->dev, "Platform information is NULL\n"); dev_info(&auxdev->dev, "Platform information is NULL\n");
ret = -ENODEV;
goto err_rem_common;
}
pkg = plat_info->package_id;
for (i = 0; i < num_resources; ++i) { for (i = 0; i < num_resources; ++i) {
struct tpmi_uncore_power_domain_info *pd_info; struct tpmi_uncore_power_domain_info *pd_info;