samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

soc: aspeed: lpc: Fix impossible judgment condition

Browse Source 
[ Upstream commit d9f0a97e859bdcef51f9c187b1eb712eb13fd3ff ]

smatch error：
drivers/soc/aspeed/aspeed-lpc-snoop.c:169
aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero

platform_get_irq() return non-zero IRQ number or negative error code,
change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this.

Fixes: 9f4f9ae81d ("drivers/misc: add Aspeed LPC snoop driver")
Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20231027020703.1231875-1-suhui@nfschina.com
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Su Hui
2025-05-15 16:00:43 +09:30
committed by Greg Kroah-Hartman
parent fc5a7a9664
commit b828083b3d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/soc/aspeed/aspeed-lpc-snoop.c
View File

@@ -166,7 +166,7 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop,
int rc; int rc;
lpc_snoop->irq = platform_get_irq(pdev, 0); lpc_snoop->irq = platform_get_irq(pdev, 0);
if (!lpc_snoop->irq) if (lpc_snoop->irq < 0)
return -ENODEV; return -ENODEV;
rc = devm_request_irq(dev, lpc_snoop->irq, rc = devm_request_irq(dev, lpc_snoop->irq,