irda: Convert IRDA_DEBUG to pr_debug
Use the normal kernel debugging mechanism which also enables dynamic_debug at the same time. Other miscellanea: o Remove sysctl for irda_debug o Remove function tracing like uses (use ftrace instead) o Coalesce formats o Realign arguments o Remove unnecessary OOM messages Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
8d326d818a
commit
955a9d202f
@@ -109,11 +109,11 @@ static void sirdev_config_fsm(struct work_struct *work)
|
||||
int ret = -1;
|
||||
unsigned delay;
|
||||
|
||||
IRDA_DEBUG(2, "%s(), <%ld>\n", __func__, jiffies);
|
||||
pr_debug("%s(), <%ld>\n", __func__, jiffies);
|
||||
|
||||
do {
|
||||
IRDA_DEBUG(3, "%s - state=0x%04x / substate=0x%04x\n",
|
||||
__func__, fsm->state, fsm->substate);
|
||||
pr_debug("%s - state=0x%04x / substate=0x%04x\n",
|
||||
__func__, fsm->state, fsm->substate);
|
||||
|
||||
next_state = fsm->state;
|
||||
delay = 0;
|
||||
@@ -287,12 +287,12 @@ int sirdev_schedule_request(struct sir_dev *dev, int initial_state, unsigned par
|
||||
{
|
||||
struct sir_fsm *fsm = &dev->fsm;
|
||||
|
||||
IRDA_DEBUG(2, "%s - state=0x%04x / param=%u\n", __func__,
|
||||
initial_state, param);
|
||||
pr_debug("%s - state=0x%04x / param=%u\n", __func__,
|
||||
initial_state, param);
|
||||
|
||||
if (down_trylock(&fsm->sem)) {
|
||||
if (in_interrupt() || in_atomic() || irqs_disabled()) {
|
||||
IRDA_DEBUG(1, "%s(), state machine busy!\n", __func__);
|
||||
pr_debug("%s(), state machine busy!\n", __func__);
|
||||
return -EWOULDBLOCK;
|
||||
} else
|
||||
down(&fsm->sem);
|
||||
@@ -345,7 +345,7 @@ int sirdev_set_dongle(struct sir_dev *dev, IRDA_DONGLE type)
|
||||
{
|
||||
int err;
|
||||
|
||||
IRDA_DEBUG(3, "%s : requesting dongle %d.\n", __func__, type);
|
||||
pr_debug("%s : requesting dongle %d.\n", __func__, type);
|
||||
|
||||
err = sirdev_schedule_dongle_open(dev, type);
|
||||
if (unlikely(err))
|
||||
@@ -380,7 +380,7 @@ int sirdev_raw_write(struct sir_dev *dev, const char *buf, int len)
|
||||
|
||||
ret = dev->drv->do_write(dev, dev->tx_buff.data, dev->tx_buff.len);
|
||||
if (ret > 0) {
|
||||
IRDA_DEBUG(3, "%s(), raw-tx started\n", __func__);
|
||||
pr_debug("%s(), raw-tx started\n", __func__);
|
||||
|
||||
dev->tx_buff.data += ret;
|
||||
dev->tx_buff.len -= ret;
|
||||
@@ -440,8 +440,8 @@ void sirdev_write_complete(struct sir_dev *dev)
|
||||
|
||||
spin_lock_irqsave(&dev->tx_lock, flags);
|
||||
|
||||
IRDA_DEBUG(3, "%s() - dev->tx_buff.len = %d\n",
|
||||
__func__, dev->tx_buff.len);
|
||||
pr_debug("%s() - dev->tx_buff.len = %d\n",
|
||||
__func__, dev->tx_buff.len);
|
||||
|
||||
if (likely(dev->tx_buff.len > 0)) {
|
||||
/* Write data left in transmit buffer */
|
||||
@@ -475,7 +475,7 @@ void sirdev_write_complete(struct sir_dev *dev)
|
||||
* restarted when the irda-thread has completed the request.
|
||||
*/
|
||||
|
||||
IRDA_DEBUG(3, "%s(), raw-tx done\n", __func__);
|
||||
pr_debug("%s(), raw-tx done\n", __func__);
|
||||
dev->raw_tx = 0;
|
||||
goto done; /* no post-frame handling in raw mode */
|
||||
}
|
||||
@@ -492,7 +492,7 @@ void sirdev_write_complete(struct sir_dev *dev)
|
||||
* re-activated.
|
||||
*/
|
||||
|
||||
IRDA_DEBUG(5, "%s(), finished with frame!\n", __func__);
|
||||
pr_debug("%s(), finished with frame!\n", __func__);
|
||||
|
||||
if ((skb=dev->tx_skb) != NULL) {
|
||||
dev->tx_skb = NULL;
|
||||
@@ -502,7 +502,7 @@ void sirdev_write_complete(struct sir_dev *dev)
|
||||
}
|
||||
|
||||
if (unlikely(dev->new_speed > 0)) {
|
||||
IRDA_DEBUG(5, "%s(), Changing speed!\n", __func__);
|
||||
pr_debug("%s(), Changing speed!\n", __func__);
|
||||
err = sirdev_schedule_speed(dev, dev->new_speed);
|
||||
if (unlikely(err)) {
|
||||
/* should never happen
|
||||
@@ -552,7 +552,7 @@ int sirdev_receive(struct sir_dev *dev, const unsigned char *cp, size_t count)
|
||||
*/
|
||||
irda_device_set_media_busy(dev->netdev, TRUE);
|
||||
dev->netdev->stats.rx_dropped++;
|
||||
IRDA_DEBUG(0, "%s; rx-drop: %zd\n", __func__, count);
|
||||
pr_debug("%s; rx-drop: %zd\n", __func__, count);
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -598,7 +598,7 @@ static netdev_tx_t sirdev_hard_xmit(struct sk_buff *skb,
|
||||
|
||||
netif_stop_queue(ndev);
|
||||
|
||||
IRDA_DEBUG(3, "%s(), skb->len = %d\n", __func__, skb->len);
|
||||
pr_debug("%s(), skb->len = %d\n", __func__, skb->len);
|
||||
|
||||
speed = irda_get_next_speed(skb);
|
||||
if ((speed != dev->speed) && (speed != -1)) {
|
||||
@@ -635,7 +635,7 @@ static netdev_tx_t sirdev_hard_xmit(struct sk_buff *skb,
|
||||
|
||||
/* Check problems */
|
||||
if(spin_is_locked(&dev->tx_lock)) {
|
||||
IRDA_DEBUG(3, "%s(), write not completed\n", __func__);
|
||||
pr_debug("%s(), write not completed\n", __func__);
|
||||
}
|
||||
|
||||
/* serialize with write completion */
|
||||
@@ -684,7 +684,7 @@ static int sirdev_ioctl(struct net_device *ndev, struct ifreq *rq, int cmd)
|
||||
|
||||
IRDA_ASSERT(dev != NULL, return -1;);
|
||||
|
||||
IRDA_DEBUG(3, "%s(), %s, (cmd=0x%X)\n", __func__, ndev->name, cmd);
|
||||
pr_debug("%s(), %s, (cmd=0x%X)\n", __func__, ndev->name, cmd);
|
||||
|
||||
switch (cmd) {
|
||||
case SIOCSBANDWIDTH: /* Set bandwidth */
|
||||
@@ -801,8 +801,6 @@ static int sirdev_open(struct net_device *ndev)
|
||||
if (!try_module_get(drv->owner))
|
||||
return -ESTALE;
|
||||
|
||||
IRDA_DEBUG(2, "%s()\n", __func__);
|
||||
|
||||
if (sirdev_alloc_buffers(dev))
|
||||
goto errout_dec;
|
||||
|
||||
@@ -819,7 +817,7 @@ static int sirdev_open(struct net_device *ndev)
|
||||
|
||||
netif_wake_queue(ndev);
|
||||
|
||||
IRDA_DEBUG(2, "%s - done, speed = %d\n", __func__, dev->speed);
|
||||
pr_debug("%s - done, speed = %d\n", __func__, dev->speed);
|
||||
|
||||
return 0;
|
||||
|
||||
@@ -839,7 +837,7 @@ static int sirdev_close(struct net_device *ndev)
|
||||
struct sir_dev *dev = netdev_priv(ndev);
|
||||
const struct sir_driver *drv;
|
||||
|
||||
// IRDA_DEBUG(0, "%s\n", __func__);
|
||||
/* pr_debug("%s\n", __func__); */
|
||||
|
||||
netif_stop_queue(ndev);
|
||||
|
||||
@@ -881,7 +879,7 @@ struct sir_dev * sirdev_get_instance(const struct sir_driver *drv, const char *n
|
||||
struct net_device *ndev;
|
||||
struct sir_dev *dev;
|
||||
|
||||
IRDA_DEBUG(0, "%s - %s\n", __func__, name);
|
||||
pr_debug("%s - %s\n", __func__, name);
|
||||
|
||||
/* instead of adding tests to protect against drv->do_write==NULL
|
||||
* at several places we refuse to create a sir_dev instance for
|
||||
@@ -939,7 +937,7 @@ int sirdev_put_instance(struct sir_dev *dev)
|
||||
{
|
||||
int err = 0;
|
||||
|
||||
IRDA_DEBUG(0, "%s\n", __func__);
|
||||
pr_debug("%s\n", __func__);
|
||||
|
||||
atomic_set(&dev->enable_rx, 0);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user