samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net/sched: fix use-after-free in taprio_dev_notifier

Browse Source 
commit b160766e26d4e2e2d6fe2294e0b02f92baefcec5 upstream.

Since taprio’s taprio_dev_notifier() isn’t protected by an
RCU read-side critical section, a race with advance_sched()
can lead to a use-after-free.

Adding rcu_read_lock() inside taprio_dev_notifier() prevents this.

Fixes: fed87cc671 ("net/sched: taprio: automatically calculate queueMaxSDU based on TC gate durations")
Cc: stable@vger.kernel.org
Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/aEzIYYxt0is9upYG@v4bel-B760M-AORUS-ELITE-AX
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Hyunwoo Kim
2025-06-13 20:54:57 -04:00
committed by Greg Kroah-Hartman
parent a8acc7080a
commit 8c5713ce1c
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
net/sched/sch_taprio.c
View File

@@ -1338,13 +1338,15 @@ static int taprio_dev_notifier(struct notifier_block *nb, unsigned long event,
stab = rtnl_dereference(q->root->stab); stab = rtnl_dereference(q->root->stab);
oper = rtnl_dereference(q->oper_sched); rcu_read_lock();
oper = rcu_dereference(q->oper_sched);
if (oper) if (oper)
taprio_update_queue_max_sdu(q, oper, stab); taprio_update_queue_max_sdu(q, oper, stab);
admin = rtnl_dereference(q->admin_sched); admin = rcu_dereference(q->admin_sched);
if (admin) if (admin)
taprio_update_queue_max_sdu(q, admin, stab); taprio_update_queue_max_sdu(q, admin, stab);
rcu_read_unlock();
break; break;
} }