samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rpmsg: qcom_smd: Fix uninitialized return variable in __qcom_smd_send()

Browse Source 
[ Upstream commit 5de775df3362090a6e90046d1f2d83fe62489aa0 ]

The "ret" variable isn't initialized if we don't enter the loop.  For
example,  if "channel->state" is not SMD_CHANNEL_OPENED.

Fixes: 33e3820dda ("rpmsg: smd: Use spinlock in tx path")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/aAkhvV0nSbrsef1P@stanley.mountain
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter
2025-04-23 20:22:05 +03:00
committed by Greg Kroah-Hartman
parent 3b726bc126
commit 85322ddd44
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/rpmsg/qcom_smd.c
View File

@@ -746,7 +746,7 @@ static int __qcom_smd_send(struct qcom_smd_channel *channel, const void *data,
__le32 hdr[5] = { cpu_to_le32(len), }; __le32 hdr[5] = { cpu_to_le32(len), };
int tlen = sizeof(hdr) + len; int tlen = sizeof(hdr) + len;
unsigned long flags; unsigned long flags;
int ret; int ret = 0;
/* Word aligned channels only accept word size aligned data */ /* Word aligned channels only accept word size aligned data */
if (channel->info_word && len % 4) if (channel->info_word && len % 4)