samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

enic: fix incorrect MTU comparison in enic_change_mtu()

Browse Source 
[ Upstream commit aaf2b2480375099c022a82023e1cd772bf1c6a5d ]

The comparison in enic_change_mtu() incorrectly used the current
netdev->mtu instead of the new new_mtu value when warning about
an MTU exceeding the port MTU. This could suppress valid warnings
or issue incorrect ones.

Fix the condition and log to properly reflect the new_mtu.

Fixes: ab123fe071 ("enic: handle mtu change for vf properly")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Acked-by: John Daley <johndale@cisco.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250628145612.476096-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Alok Tiwari
2025-06-28 07:56:05 -07:00
committed by Greg Kroah-Hartman
parent a133683c05
commit 744cd8baff
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/cisco/enic/enic_main.c
View File

@@ -2057,10 +2057,10 @@ static int enic_change_mtu(struct net_device *netdev, int new_mtu)
if (enic_is_dynamic(enic) || enic_is_sriov_vf(enic)) if (enic_is_dynamic(enic) || enic_is_sriov_vf(enic))
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (netdev->mtu > enic->port_mtu) if (new_mtu > enic->port_mtu)
netdev_warn(netdev, netdev_warn(netdev,
"interface MTU (%d) set higher than port MTU (%d)\n", "interface MTU (%d) set higher than port MTU (%d)\n",
netdev->mtu, enic->port_mtu); new_mtu, enic->port_mtu);
return _enic_change_mtu(netdev, new_mtu); return _enic_change_mtu(netdev, new_mtu);
} }