samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: gpio-altera: Remove gpiochip on probe failure.

Browse Source 
On failure to setup the irq altera_gpio_probe would return an error
but not go to cleanup. This resulted in kernel fault
"Unable to handle kernel paging request at virtual address xxxxxxxx"
later on in of_gpiochip_find_and_xlate.

Signed-off-by: Phil Reid <preid@electromag.com.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Phil Reid
2016-01-15 11:32:22 +08:00
committed by Linus Walleij
parent 92e963f50f
commit 73c13c8349
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpio/gpio-altera.c
View File

@@ -312,8 +312,8 @@ static int altera_gpio_probe(struct platform_device *pdev)
handle_simple_irq, IRQ_TYPE_NONE); handle_simple_irq, IRQ_TYPE_NONE);
if (ret) { if (ret) {
dev_info(&pdev->dev, "could not add irqchip\n"); dev_err(&pdev->dev, "could not add irqchip\n");
return ret; goto teardown;
} }
gpiochip_set_chained_irqchip(&altera_gc->mmchip.gc, gpiochip_set_chained_irqchip(&altera_gc->mmchip.gc,
@@ -326,6 +326,7 @@ static int altera_gpio_probe(struct platform_device *pdev)
skip_irq: skip_irq:
return 0; return 0;
teardown: teardown:
of_mm_gpiochip_remove(&altera_gc->mmchip);
pr_err("%s: registration failed with status %d\n", pr_err("%s: registration failed with status %d\n",
node->full_name, ret); node->full_name, ret);