samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: dwc3: qcom: Don't leave BCR asserted

Browse Source 
commit ef8abc0ba49ce717e6bc4124e88e59982671f3b5 upstream.

Leaving the USB BCR asserted prevents the associated GDSC to turn on. This
blocks any subsequent attempts of probing the device, e.g. after a probe
deferral, with the following showing in the log:

[    1.332226] usb30_prim_gdsc status stuck at 'off'

Leave the BCR deasserted when exiting the driver to avoid this issue.

Cc: stable <stable@kernel.org>
Fixes: a4333c3a6b ("usb: dwc3: Add Qualcomm DWC3 glue driver")
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250709132900.3408752-1-krishna.kurapati@oss.qualcomm.com
[ adapted to individual clock management instead of bulk clock operations ]
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Krishna Kurapati
2025-07-09 18:59:00 +05:30
committed by Greg Kroah-Hartman
parent 824fa25c85
commit 6cfbff5f8d
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/usb/dwc3/dwc3-qcom.c
View File

@@ -854,13 +854,13 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
ret = reset_control_deassert(qcom->resets); ret = reset_control_deassert(qcom->resets);
if (ret) { if (ret) {
dev_err(&pdev->dev, "failed to deassert resets, err=%d\n", ret); dev_err(&pdev->dev, "failed to deassert resets, err=%d\n", ret);
goto reset_assert; return ret;
} }
ret = dwc3_qcom_clk_init(qcom, of_clk_get_parent_count(np)); ret = dwc3_qcom_clk_init(qcom, of_clk_get_parent_count(np));
if (ret) { if (ret) {
dev_err_probe(dev, ret, "failed to get clocks\n"); dev_err_probe(dev, ret, "failed to get clocks\n");
goto reset_assert; return ret;
} }
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -964,8 +964,6 @@ clk_disable:
clk_disable_unprepare(qcom->clks[i]); clk_disable_unprepare(qcom->clks[i]);
clk_put(qcom->clks[i]); clk_put(qcom->clks[i]);
} }
reset_assert:
reset_control_assert(qcom->resets);
return ret; return ret;
} }
@@ -995,8 +993,6 @@ static void dwc3_qcom_remove(struct platform_device *pdev)
qcom->num_clocks = 0; qcom->num_clocks = 0;
dwc3_qcom_interconnect_exit(qcom); dwc3_qcom_interconnect_exit(qcom);
reset_control_assert(qcom->resets);
pm_runtime_allow(dev); pm_runtime_allow(dev);
pm_runtime_disable(dev); pm_runtime_disable(dev);
} }