samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dmaengine: idxd: fix memory leak in error handling path of idxd_setup_groups

Browse Source 
commit aa6f4f945b10eac57aed46154ae7d6fada7fccc7 upstream.

Memory allocated for groups is not freed if an error occurs during
idxd_setup_groups(). To fix it, free the allocated memory in the reverse
order of allocation before exiting the function in case of an error.

Fixes: defe49f960 ("dmaengine: idxd: fix group conf_dev lifetime")
Cc: stable@vger.kernel.org
Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
Link: https://lore.kernel.org/r/20250404120217.48772-4-xueshuai@linux.alibaba.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Shuai Xue
2025-04-04 20:02:11 +08:00
committed by Greg Kroah-Hartman
parent 9ba964b17f
commit 6ab9526e32
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/dma/idxd/init.c
View File

@@ -316,6 +316,7 @@ static int idxd_setup_groups(struct idxd_device *idxd)
rc = dev_set_name(conf_dev, "group%d.%d", idxd->id, group->id); rc = dev_set_name(conf_dev, "group%d.%d", idxd->id, group->id);
if (rc < 0) { if (rc < 0) {
put_device(conf_dev); put_device(conf_dev);
kfree(group);
goto err; goto err;
} }
@@ -340,7 +341,10 @@ static int idxd_setup_groups(struct idxd_device *idxd)
while (--i >= 0) { while (--i >= 0) {
group = idxd->groups[i]; group = idxd->groups[i];
put_device(group_confdev(group)); put_device(group_confdev(group));
kfree(group);
} }
kfree(idxd->groups);
return rc; return rc;
} }