ext4: factor out ext4_get_maxbytes()
commit dbe27f06fa38b9bfc598f8864ae1c5d5831d9992 upstream. There are several locations that get the correct maxbytes value based on the inode's block type. It would be beneficial to extract a common helper function to make the code more clear. Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Reviewed-by: Baokun Li <libaokun1@huawei.com> Link: https://patch.msgid.link/20250506012009.3896990-3-yi.zhang@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
223091c989
commit
68cea04f1f
@@ -3351,6 +3351,13 @@ static inline unsigned int ext4_flex_bg_size(struct ext4_sb_info *sbi)
|
||||
return 1 << sbi->s_log_groups_per_flex;
|
||||
}
|
||||
|
||||
static inline loff_t ext4_get_maxbytes(struct inode *inode)
|
||||
{
|
||||
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
||||
return inode->i_sb->s_maxbytes;
|
||||
return EXT4_SB(inode->i_sb)->s_bitmap_maxbytes;
|
||||
}
|
||||
|
||||
#define ext4_std_error(sb, errno) \
|
||||
do { \
|
||||
if ((errno)) \
|
||||
|
@@ -4970,12 +4970,7 @@ static const struct iomap_ops ext4_iomap_xattr_ops = {
|
||||
|
||||
static int ext4_fiemap_check_ranges(struct inode *inode, u64 start, u64 *len)
|
||||
{
|
||||
u64 maxbytes;
|
||||
|
||||
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
||||
maxbytes = inode->i_sb->s_maxbytes;
|
||||
else
|
||||
maxbytes = EXT4_SB(inode->i_sb)->s_bitmap_maxbytes;
|
||||
u64 maxbytes = ext4_get_maxbytes(inode);
|
||||
|
||||
if (*len == 0)
|
||||
return -EINVAL;
|
||||
|
@@ -898,12 +898,7 @@ static int ext4_file_open(struct inode *inode, struct file *filp)
|
||||
loff_t ext4_llseek(struct file *file, loff_t offset, int whence)
|
||||
{
|
||||
struct inode *inode = file->f_mapping->host;
|
||||
loff_t maxbytes;
|
||||
|
||||
if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)))
|
||||
maxbytes = EXT4_SB(inode->i_sb)->s_bitmap_maxbytes;
|
||||
else
|
||||
maxbytes = inode->i_sb->s_maxbytes;
|
||||
loff_t maxbytes = ext4_get_maxbytes(inode);
|
||||
|
||||
switch (whence) {
|
||||
default:
|
||||
|
Reference in New Issue
Block a user