media: imx-jpeg: Move mxc_jpeg_free_slot_data() ahead
commit 46e9c092f850bd7b4d06de92d3d21877f49a3fcb upstream.
Move function mxc_jpeg_free_slot_data() above mxc_jpeg_alloc_slot_data()
allowing to call that function during allocation failures.
No functional changes are made.
Fixes: 2db16c6ed7
("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder")
Cc: stable@vger.kernel.org
Signed-off-by: Ming Qian <ming.qian@oss.nxp.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
350d4af049
commit
683a1db680
@@ -752,6 +752,26 @@ static int mxc_get_free_slot(struct mxc_jpeg_slot_data *slot_data)
|
||||
return -1;
|
||||
}
|
||||
|
||||
static void mxc_jpeg_free_slot_data(struct mxc_jpeg_dev *jpeg)
|
||||
{
|
||||
/* free descriptor for decoding/encoding phase */
|
||||
dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc),
|
||||
jpeg->slot_data.desc,
|
||||
jpeg->slot_data.desc_handle);
|
||||
|
||||
/* free descriptor for encoder configuration phase / decoder DHT */
|
||||
dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc),
|
||||
jpeg->slot_data.cfg_desc,
|
||||
jpeg->slot_data.cfg_desc_handle);
|
||||
|
||||
/* free configuration stream */
|
||||
dma_free_coherent(jpeg->dev, MXC_JPEG_MAX_CFG_STREAM,
|
||||
jpeg->slot_data.cfg_stream_vaddr,
|
||||
jpeg->slot_data.cfg_stream_handle);
|
||||
|
||||
jpeg->slot_data.used = false;
|
||||
}
|
||||
|
||||
static bool mxc_jpeg_alloc_slot_data(struct mxc_jpeg_dev *jpeg)
|
||||
{
|
||||
struct mxc_jpeg_desc *desc;
|
||||
@@ -798,26 +818,6 @@ err:
|
||||
return false;
|
||||
}
|
||||
|
||||
static void mxc_jpeg_free_slot_data(struct mxc_jpeg_dev *jpeg)
|
||||
{
|
||||
/* free descriptor for decoding/encoding phase */
|
||||
dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc),
|
||||
jpeg->slot_data.desc,
|
||||
jpeg->slot_data.desc_handle);
|
||||
|
||||
/* free descriptor for encoder configuration phase / decoder DHT */
|
||||
dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc),
|
||||
jpeg->slot_data.cfg_desc,
|
||||
jpeg->slot_data.cfg_desc_handle);
|
||||
|
||||
/* free configuration stream */
|
||||
dma_free_coherent(jpeg->dev, MXC_JPEG_MAX_CFG_STREAM,
|
||||
jpeg->slot_data.cfg_stream_vaddr,
|
||||
jpeg->slot_data.cfg_stream_handle);
|
||||
|
||||
jpeg->slot_data.used = false;
|
||||
}
|
||||
|
||||
static void mxc_jpeg_check_and_set_last_buffer(struct mxc_jpeg_ctx *ctx,
|
||||
struct vb2_v4l2_buffer *src_buf,
|
||||
struct vb2_v4l2_buffer *dst_buf)
|
||||
|
Reference in New Issue
Block a user