samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

UPSTREAM: mm: fix list corruption in put_pages_list

Browse Source 
My recent change to put_pages_list() dereferences folio->lru.next after
returning the folio to the page allocator.  Usually this is now on the pcp
list with other free folios, so we try to free an already-free folio.
This only happens with lists that have more than 15 entries, so it wasn't
immediately discovered.  Revert to using list_for_each_safe() so we
dereference lru.next before disposing of the folio.

Link: https://lkml.kernel.org/r/20240306212749.1823380-1-willy@infradead.org
Fixes: 24835f899c01 ("mm: use free_unref_folios() in put_pages_list()")
Change-Id: I9f9e2d354da7b51c5e47d3c1dff3df44460b6df8
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reported-by: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
Closes: https://lore.kernel.org/intel-gfx/SJ1PR11MB61292145F3B79DA58ADDDA63B9232@SJ1PR11MB6129.namprd11.prod.outlook.com/
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
(cherry picked from commit b555895c313511830762dbb2f469587a822c1759)
Bug: 419599659
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
This commit is contained in:
Matthew Wilcox (Oracle)
2024-03-06 21:27:30 +00:00
committed by Kalesh Singh
parent f61f355bdc
commit 4d61851d14
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mm/swap.c
View File

@@ -134,10 +134,10 @@ EXPORT_SYMBOL(__folio_put);
void put_pages_list(struct list_head *pages) void put_pages_list(struct list_head *pages)
{ {
struct folio_batch fbatch; struct folio_batch fbatch;
struct folio *folio; struct folio *folio, *next;
folio_batch_init(&fbatch); folio_batch_init(&fbatch);
list_for_each_entry(folio, pages, lru) { list_for_each_entry_safe(folio, next, pages, lru) {
if (!folio_put_testzero(folio)) if (!folio_put_testzero(folio))
continue; continue;
if (folio_test_large(folio)) { if (folio_test_large(folio)) {