Add samsung specific changes

2025-08-11 14:29:00 +02:00
parent c66122e619
commit 4d134a1294
2688 changed files with 1127995 additions and 11475 deletions
--- a/drivers/remoteproc/qcom_common.c
+++ b/drivers/remoteproc/qcom_common.c
@@ -5,6 +5,7 @@
 * Copyright (C) 2016 Linaro Ltd
 * Copyright (C) 2015 Sony Mobile Communications Inc
 * Copyright (c) 2012-2013, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All rights reserved.
 */

 #include <linux/firmware.h>
@@ -12,20 +13,29 @@
 #include <linux/module.h>
 #include <linux/notifier.h>
 #include <linux/remoteproc.h>
-#include <linux/remoteproc/qcom_rproc.h>
 #include <linux/rpmsg/qcom_glink.h>
 #include <linux/rpmsg/qcom_smd.h>
 #include <linux/slab.h>
 #include <linux/soc/qcom/mdt_loader.h>
 #include <linux/soc/qcom/smem.h>
+#include <linux/devcoredump.h>
+#include <trace/hooks/remoteproc.h>
+#include <trace/events/rproc_qcom.h>

+#include "remoteproc_elf_helpers.h"
 #include "remoteproc_internal.h"
 #include "qcom_common.h"

+#define SSR_NOTIF_TIMEOUT CONFIG_RPROC_SSR_NOTIF_TIMEOUT
+
 #define to_glink_subdev(d) container_of(d, struct qcom_rproc_glink, subdev)
 #define to_smd_subdev(d) container_of(d, struct qcom_rproc_subdev, subdev)
 #define to_ssr_subdev(d) container_of(d, struct qcom_rproc_ssr, subdev)

+#define GLINK_SUBDEV_NAME	"glink"
+#define SMD_SUBDEV_NAME		"smd"
+#define SSR_SUBDEV_NAME		"ssr"
+
 #define MAX_NUM_OF_SS           10
 #define MAX_REGION_NAME_LENGTH  16
 #define SBL_MINIDUMP_SMEM_ID	602
@@ -84,12 +94,66 @@ struct minidump_global_toc {
 struct qcom_ssr_subsystem {
 	const char *name;
 	struct srcu_notifier_head notifier_list;
+	struct srcu_notifier_head early_notifier_list;
 	struct list_head list;
 };

+static struct kobject *sysfs_kobject;
+bool qcom_device_shutdown_in_progress;
+EXPORT_SYMBOL(qcom_device_shutdown_in_progress);
+
+static bool qcom_collect_both_coredumps;
+
 static LIST_HEAD(qcom_ssr_subsystem_list);
 static DEFINE_MUTEX(qcom_ssr_subsys_lock);

+void (*rproc_recovery_set_fn)(struct rproc *rproc) = NULL;
+EXPORT_SYMBOL_GPL(rproc_recovery_set_fn);
+
+static const char * const ssr_timeout_msg = "srcu notifier chain for %s:%s taking too long";
+
+static ssize_t qcom_rproc_shutdown_request_store(struct kobject *kobj, struct kobj_attribute *attr,
+						 const char *buf, size_t count)
+{
+	bool val;
+	int ret;
+
+	ret = kstrtobool(buf, &val);
+	if (ret)
+		return ret;
+
+	qcom_device_shutdown_in_progress = val;
+	pr_info("qcom rproc: Device shutdown requested: %s\n", val ? "true" : "false");
+	return count;
+}
+static struct kobj_attribute shutdown_requested_attr = __ATTR(shutdown_in_progress, 0220, NULL,
+							  qcom_rproc_shutdown_request_store);
+
+static ssize_t qcom_collect_both_coredumps_show(struct kobject *kobj, struct kobj_attribute *attr,
+						char *buf)
+{
+	return scnprintf(buf, 3, "%u\n", qcom_collect_both_coredumps);
+}
+
+static ssize_t qcom_collect_both_coredumps_store(struct kobject *kobj, struct kobj_attribute *attr,
+						 const char *buf, size_t count)
+{
+	bool val;
+	int ret;
+
+	ret = kstrtobool(buf, &val);
+	if (ret)
+		return ret;
+
+	qcom_collect_both_coredumps = val;
+	pr_info("qcom rproc: Collect both coredumps: %s\n", val ? "true" : "false");
+	return count;
+}
+
+static struct kobj_attribute both_coredumps_attr =
+	__ATTR(collect_both_coredumps, 0644, qcom_collect_both_coredumps_show,
+	       qcom_collect_both_coredumps_store);
+
 static void qcom_minidump_cleanup(struct rproc *rproc)
 {
 	struct rproc_dump_segment *entry, *tmp;
@@ -102,15 +166,15 @@ static void qcom_minidump_cleanup(struct rproc *rproc)
 }

 static int qcom_add_minidump_segments(struct rproc *rproc, struct minidump_subsystem *subsystem,
-			void (*rproc_dumpfn_t)(struct rproc *rproc, struct rproc_dump_segment *segment,
-				void *dest, size_t offset, size_t size))
+				      rproc_dumpfn_t dumpfn)
 {
 	struct minidump_region __iomem *ptr;
 	struct minidump_region region;
 	int seg_cnt, i;
 	dma_addr_t da;
 	size_t size;
-	char *name;
+	char *name, *dbg_buf_name = "md_dbg_buf";
+	int len = strlen(dbg_buf_name);

 	if (WARN_ON(!list_empty(&rproc->dump_segments))) {
 		dev_err(&rproc->dev, "dump segment list already populated\n");
@@ -132,8 +196,15 @@ static int qcom_add_minidump_segments(struct rproc *rproc, struct minidump_subsy
 				return -ENOMEM;
 			}
 			da = le64_to_cpu(region.address);
-			size = le64_to_cpu(region.size);
-			rproc_coredump_add_custom_segment(rproc, da, size, rproc_dumpfn_t, name);
+			size = le32_to_cpu(region.size);
+			if (le32_to_cpu(subsystem->encryption_status) != MINIDUMP_SS_ENCR_DONE) {
+				if (!i && len < MAX_REGION_NAME_LENGTH &&
+				    !strcmp(name, dbg_buf_name))
+					rproc_coredump_add_custom_segment(rproc, da, size, dumpfn,
+									  name);
+				break;
+			}
+			rproc_coredump_add_custom_segment(rproc, da, size, dumpfn, name);
 		}
 	}

@@ -141,10 +212,114 @@ static int qcom_add_minidump_segments(struct rproc *rproc, struct minidump_subsy
 	return 0;
 }

-void qcom_minidump(struct rproc *rproc, unsigned int minidump_id,
-		void (*rproc_dumpfn_t)(struct rproc *rproc,
-		struct rproc_dump_segment *segment, void *dest, size_t offset,
-		size_t size))
+static void qcom_rproc_minidump(struct rproc *rproc, struct device *md_dev)
+{
+	struct rproc_dump_segment *segment;
+	void *shdr;
+	void *ehdr;
+	size_t data_size;
+	size_t strtbl_size = 0;
+	size_t strtbl_index = 1;
+	size_t offset;
+	void *data;
+	u8 class = rproc->elf_class;
+	int shnum;
+	unsigned int dump_conf = rproc->dump_conf;
+	char *str_tbl = "STR_TBL";
+
+	if (list_empty(&rproc->dump_segments) ||
+	    dump_conf == RPROC_COREDUMP_DISABLED)
+		return;
+
+	if (class == ELFCLASSNONE) {
+		dev_err(&rproc->dev, "Elf class is not set\n");
+		return;
+	}
+
+	/*
+	 * We allocate two extra section headers. The first one is null.
+	 * Second section header is for the string table. Also space is
+	 * allocated for string table.
+	 */
+	data_size = elf_size_of_hdr(class) + 2 * elf_size_of_shdr(class);
+	shnum = 2;
+
+	/* the extra byte is for the null character at index 0 */
+	strtbl_size += strlen(str_tbl) + 2;
+
+	list_for_each_entry(segment, &rproc->dump_segments, node) {
+		data_size += elf_size_of_shdr(class);
+		strtbl_size += strlen(segment->priv) + 1;
+		data_size += segment->size;
+		shnum++;
+	}
+
+	data_size += strtbl_size;
+
+	data = vmalloc(data_size);
+	if (!data)
+		return;
+
+	ehdr = data;
+	memset(ehdr, 0, elf_size_of_hdr(class));
+	/* e_ident field is common for both elf32 and elf64 */
+	elf_hdr_init_ident(ehdr, class);
+	elf_hdr_set_e_type(class, ehdr, ET_CORE);
+	elf_hdr_set_e_machine(class, ehdr, rproc->elf_machine);
+	elf_hdr_set_e_version(class, ehdr, EV_CURRENT);
+	elf_hdr_set_e_entry(class, ehdr, rproc->bootaddr);
+	elf_hdr_set_e_shoff(class, ehdr, elf_size_of_hdr(class));
+	elf_hdr_set_e_ehsize(class, ehdr, elf_size_of_hdr(class));
+	elf_hdr_set_e_shentsize(class, ehdr, elf_size_of_shdr(class));
+	elf_hdr_set_e_shnum(class, ehdr, shnum);
+	elf_hdr_set_e_shstrndx(class, ehdr, 1);
+
+	/*
+	 * The zeroth index of the section header is reserved and is rarely used.
+	 * Set the section header as null (SHN_UNDEF) and move to the next one.
+	 */
+	shdr = data + elf_hdr_get_e_shoff(class, ehdr);
+	memset(shdr, 0, elf_size_of_shdr(class));
+	shdr += elf_size_of_shdr(class);
+
+	/* Initialize the string table. */
+	offset = elf_hdr_get_e_shoff(class, ehdr) +
+		 elf_size_of_shdr(class) * elf_hdr_get_e_shnum(class, ehdr);
+	memset(data + offset, 0, strtbl_size);
+
+	/* Fill in the string table section header. */
+	memset(shdr, 0, elf_size_of_shdr(class));
+	elf_shdr_set_sh_type(class, shdr, SHT_STRTAB);
+	elf_shdr_set_sh_offset(class, shdr, offset);
+	elf_shdr_set_sh_size(class, shdr, strtbl_size);
+	elf_shdr_set_sh_entsize(class, shdr, 0);
+	elf_shdr_set_sh_flags(class, shdr, 0);
+	elf_shdr_set_sh_name(class, shdr, elf_strtbl_add(str_tbl, ehdr, class, &strtbl_index));
+	offset += elf_shdr_get_sh_size(class, shdr);
+	shdr += elf_size_of_shdr(class);
+
+	list_for_each_entry(segment, &rproc->dump_segments, node) {
+		memset(shdr, 0, elf_size_of_shdr(class));
+		elf_shdr_set_sh_type(class, shdr, SHT_PROGBITS);
+		elf_shdr_set_sh_offset(class, shdr, offset);
+		elf_shdr_set_sh_addr(class, shdr, segment->da);
+		elf_shdr_set_sh_size(class, shdr, segment->size);
+		elf_shdr_set_sh_entsize(class, shdr, 0);
+		elf_shdr_set_sh_flags(class, shdr, SHF_WRITE);
+		elf_shdr_set_sh_name(class, shdr,
+				     elf_strtbl_add(segment->priv, ehdr, class, &strtbl_index));
+
+		/* No need to copy segments for inline dumps */
+		segment->dump(rproc, segment, data + offset, 0, segment->size);
+		offset += elf_shdr_get_sh_size(class, shdr);
+		shdr += elf_size_of_shdr(class);
+	}
+
+	dev_coredumpv(md_dev, data, data_size, GFP_KERNEL);
+}
+
+void qcom_minidump(struct rproc *rproc, struct device *md_dev, unsigned int minidump_id,
+		   rproc_dumpfn_t dumpfn, bool both_dumps)
 {
 	int ret;
 	struct minidump_subsystem *subsystem;
@@ -172,10 +347,12 @@ void qcom_minidump(struct rproc *rproc, unsigned int minidump_id,
 		return rproc_coredump(rproc);
 	}

-	if (le32_to_cpu(subsystem->encryption_status) != MINIDUMP_SS_ENCR_DONE) {
-		dev_err(&rproc->dev, "Minidump not ready, skipping\n");
-		return;
-	}
+	if (both_dumps && IS_ENABLED(CONFIG_QCOM_RPROC_BOTH_DUMPS) &&
+	    qcom_collect_both_coredumps)
+		rproc_coredump(rproc);
+
+	if (le32_to_cpu(subsystem->encryption_status) != MINIDUMP_SS_ENCR_DONE)
+		dev_err(&rproc->dev, "encryption_status != MINIDUMP_SS_ENCR_DONE\n");

 	/**
 	 * Clear out the dump segments populated by parse_fw before
@@ -183,29 +360,72 @@ void qcom_minidump(struct rproc *rproc, unsigned int minidump_id,
 	 */
 	rproc_coredump_cleanup(rproc);

-	ret = qcom_add_minidump_segments(rproc, subsystem, rproc_dumpfn_t);
+	ret = qcom_add_minidump_segments(rproc, subsystem, dumpfn);
 	if (ret) {
 		dev_err(&rproc->dev, "Failed with error: %d while adding minidump entries\n", ret);
 		goto clean_minidump;
 	}
-	rproc_coredump_using_sections(rproc);
+
+	if (rproc->elf_class == ELFCLASS64)
+		qcom_rproc_minidump(rproc, md_dev);
+	else
+		rproc_coredump(rproc);
+
 clean_minidump:
 	qcom_minidump_cleanup(rproc);
 }
 EXPORT_SYMBOL_GPL(qcom_minidump);

+static int glink_early_ssr_notifier_event(struct notifier_block *this,
+					   unsigned long code, void *data)
+{
+	struct qcom_rproc_glink *glink = container_of(this, struct qcom_rproc_glink, nb);
+
+	trace_rproc_qcom_event(dev_name(glink->dev->parent), GLINK_SUBDEV_NAME, "prepare");
+
+	qcom_glink_early_ssr_notify(glink->edge);
+	return NOTIFY_DONE;
+}
+
 static int glink_subdev_start(struct rproc_subdev *subdev)
 {
 	struct qcom_rproc_glink *glink = to_glink_subdev(subdev);

-	glink->edge = qcom_glink_smem_register(glink->dev, glink->node);
+	trace_rproc_qcom_event(dev_name(glink->dev->parent), GLINK_SUBDEV_NAME, "start");

-	return PTR_ERR_OR_ZERO(glink->edge);
+	glink->edge = qcom_glink_smem_register(glink->dev, glink->node);
+	if (IS_ERR(glink->edge)) {
+		dev_err(glink->dev, "Failed to register glink smem\n");
+		return PTR_ERR_OR_ZERO(glink->edge);
+	}
+
+	glink->nb.notifier_call = glink_early_ssr_notifier_event;
+
+	glink->notifier_handle = qcom_register_early_ssr_notifier(glink->ssr_name, &glink->nb);
+	if (IS_ERR(glink->notifier_handle)) {
+		dev_err(glink->dev, "Failed to register for SSR notifier\n");
+		glink->notifier_handle = NULL;
+	}
+
+	return qcom_glink_smem_start(glink->edge);
 }

 static void glink_subdev_stop(struct rproc_subdev *subdev, bool crashed)
 {
 	struct qcom_rproc_glink *glink = to_glink_subdev(subdev);
+	struct rproc *rproc = container_of(glink->dev, struct rproc, dev);
+	int ret;
+
+	if (!glink->edge || (crashed && rproc->recovery_disabled))
+		return;
+
+	trace_rproc_qcom_event(dev_name(glink->dev->parent), GLINK_SUBDEV_NAME,
+			       crashed ? "crash stop" : "stop");
+
+	ret = qcom_unregister_early_ssr_notifier(glink->notifier_handle, &glink->nb);
+	if (ret)
+		dev_err(glink->dev, "Error in unregistering notifier\n");
+	glink->notifier_handle = NULL;

 	qcom_glink_smem_unregister(glink->edge);
 	glink->edge = NULL;
@@ -215,6 +435,8 @@ static void glink_subdev_unprepare(struct rproc_subdev *subdev)
 {
 	struct qcom_rproc_glink *glink = to_glink_subdev(subdev);

+	trace_rproc_qcom_event(dev_name(glink->dev->parent), GLINK_SUBDEV_NAME, "unprepare");
+
 	qcom_glink_ssr_notify(glink->ssr_name);
 }

@@ -309,6 +531,8 @@ static int smd_subdev_start(struct rproc_subdev *subdev)
 {
 	struct qcom_rproc_subdev *smd = to_smd_subdev(subdev);

+	trace_rproc_qcom_event(dev_name(smd->dev->parent), SMD_SUBDEV_NAME, "start");
+
 	smd->edge = qcom_smd_register_edge(smd->dev, smd->node);

 	return PTR_ERR_OR_ZERO(smd->edge);
@@ -318,6 +542,11 @@ static void smd_subdev_stop(struct rproc_subdev *subdev, bool crashed)
 {
 	struct qcom_rproc_subdev *smd = to_smd_subdev(subdev);

+	if (!smd->edge)
+		return;
+	trace_rproc_qcom_event(dev_name(smd->dev->parent), SMD_SUBDEV_NAME,
+			       crashed ? "crash stop" : "stop");
+
 	qcom_smd_unregister_edge(smd->edge);
 	smd->edge = NULL;
 }
@@ -375,6 +604,7 @@ static struct qcom_ssr_subsystem *qcom_ssr_get_subsys(const char *name)
 	}
 	info->name = kstrdup_const(name, GFP_KERNEL);
 	srcu_init_notifier_head(&info->notifier_list);
+	srcu_init_notifier_head(&info->early_notifier_list);

 	/* Add to global notification list */
 	list_add_tail(&info->list, &qcom_ssr_subsystem_list);
@@ -384,6 +614,34 @@ out:
 	return info;
 }

+void *qcom_register_early_ssr_notifier(const char *name, struct notifier_block *nb)
+{
+	struct qcom_ssr_subsystem *info;
+
+	info = qcom_ssr_get_subsys(name);
+	if (IS_ERR(info))
+		return info;
+
+	srcu_notifier_chain_register(&info->early_notifier_list, nb);
+
+	return &info->early_notifier_list;
+}
+EXPORT_SYMBOL(qcom_register_early_ssr_notifier);
+
+int qcom_unregister_early_ssr_notifier(void *notify, struct notifier_block *nb)
+{
+	return srcu_notifier_chain_unregister(notify, nb);
+}
+EXPORT_SYMBOL(qcom_unregister_early_ssr_notifier);
+
+void qcom_notify_early_ssr_clients(struct rproc_subdev *subdev)
+{
+	struct qcom_rproc_ssr *ssr = to_ssr_subdev(subdev);
+
+	srcu_notifier_call_chain(&ssr->info->early_notifier_list, QCOM_SSR_BEFORE_SHUTDOWN, NULL);
+}
+EXPORT_SYMBOL(qcom_notify_early_ssr_clients);
+
 /**
 * qcom_register_ssr_notifier() - register SSR notification handler
 * @name:	Subsystem's SSR name
@@ -410,6 +668,22 @@ void *qcom_register_ssr_notifier(const char *name, struct notifier_block *nb)
 }
 EXPORT_SYMBOL_GPL(qcom_register_ssr_notifier);

+static void ssr_notif_timeout_handler(struct timer_list *t)
+{
+	struct qcom_rproc_ssr *ssr = from_timer(ssr, t, timer);
+
+	if (IS_ENABLED(CONFIG_QCOM_PANIC_ON_NOTIF_TIMEOUT) &&
+	    system_state != SYSTEM_RESTART &&
+	    system_state != SYSTEM_POWER_OFF &&
+	    system_state != SYSTEM_HALT &&
+	    !qcom_device_shutdown_in_progress)
+		panic(ssr_timeout_msg, ssr->info->name, subdevice_state_string[ssr->notification]);
+	else
+		WARN(1, ssr_timeout_msg, ssr->info->name,
+		     subdevice_state_string[ssr->notification]);
+
+}
+
 /**
 * qcom_unregister_ssr_notifier() - unregister SSR notification handler
 * @notify:	subsystem cookie returned from qcom_register_ssr_notifier
@@ -426,6 +700,16 @@ int qcom_unregister_ssr_notifier(void *notify, struct notifier_block *nb)
 }
 EXPORT_SYMBOL_GPL(qcom_unregister_ssr_notifier);

+static inline void notify_ssr_clients(struct qcom_rproc_ssr *ssr, struct qcom_ssr_notify_data *data)
+{
+	unsigned long timeout;
+
+	timeout = jiffies + msecs_to_jiffies(SSR_NOTIF_TIMEOUT);
+	mod_timer(&ssr->timer, timeout);
+	srcu_notifier_call_chain(&ssr->info->notifier_list, ssr->notification, data);
+	del_timer_sync(&ssr->timer);
+}
+
 static int ssr_notify_prepare(struct rproc_subdev *subdev)
 {
 	struct qcom_rproc_ssr *ssr = to_ssr_subdev(subdev);
@@ -434,8 +718,10 @@ static int ssr_notify_prepare(struct rproc_subdev *subdev)
 		.crashed = false,
 	};

-	srcu_notifier_call_chain(&ssr->info->notifier_list,
-				 QCOM_SSR_BEFORE_POWERUP, &data);
+	trace_rproc_qcom_event(ssr->info->name, SSR_SUBDEV_NAME, "prepare");
+
+	ssr->notification = QCOM_SSR_BEFORE_POWERUP;
+	notify_ssr_clients(ssr, &data);
 	return 0;
 }

@@ -447,8 +733,10 @@ static int ssr_notify_start(struct rproc_subdev *subdev)
 		.crashed = false,
 	};

-	srcu_notifier_call_chain(&ssr->info->notifier_list,
-				 QCOM_SSR_AFTER_POWERUP, &data);
+	trace_rproc_qcom_event(ssr->info->name, SSR_SUBDEV_NAME, "start");
+
+	ssr->notification = QCOM_SSR_AFTER_POWERUP;
+	notify_ssr_clients(ssr, &data);
 	return 0;
 }

@@ -460,8 +748,10 @@ static void ssr_notify_stop(struct rproc_subdev *subdev, bool crashed)
 		.crashed = crashed,
 	};

-	srcu_notifier_call_chain(&ssr->info->notifier_list,
-				 QCOM_SSR_BEFORE_SHUTDOWN, &data);
+	trace_rproc_qcom_event(ssr->info->name, SSR_SUBDEV_NAME, crashed ? "crash stop" : "stop");
+
+	ssr->notification = QCOM_SSR_BEFORE_SHUTDOWN;
+	notify_ssr_clients(ssr, &data);
 }

 static void ssr_notify_unprepare(struct rproc_subdev *subdev)
@@ -472,8 +762,10 @@ static void ssr_notify_unprepare(struct rproc_subdev *subdev)
 		.crashed = false,
 	};

-	srcu_notifier_call_chain(&ssr->info->notifier_list,
-				 QCOM_SSR_AFTER_SHUTDOWN, &data);
+	trace_rproc_qcom_event(ssr->info->name, SSR_SUBDEV_NAME, "unprepare");
+
+	ssr->notification = QCOM_SSR_AFTER_SHUTDOWN;
+	notify_ssr_clients(ssr, &data);
 }

 /**
@@ -497,6 +789,8 @@ void qcom_add_ssr_subdev(struct rproc *rproc, struct qcom_rproc_ssr *ssr,
 		return;
 	}

+	timer_setup(&ssr->timer, ssr_notif_timeout_handler, 0);
+
 	ssr->info = info;
 	ssr->subdev.prepare = ssr_notify_prepare;
 	ssr->subdev.start = ssr_notify_start;
@@ -519,5 +813,90 @@ void qcom_remove_ssr_subdev(struct rproc *rproc, struct qcom_rproc_ssr *ssr)
 }
 EXPORT_SYMBOL_GPL(qcom_remove_ssr_subdev);

+static void qcom_check_ssr_status(void *data, struct rproc *rproc)
+{
+	if (!atomic_read(&rproc->power) ||
+	    rproc->state == RPROC_RUNNING ||
+	    qcom_device_shutdown_in_progress ||
+	    system_state == SYSTEM_RESTART ||
+	    system_state == SYSTEM_POWER_OFF ||
+	    system_state == SYSTEM_HALT)
+		return;
+
+	panic("Panicking, remoteproc %s failed to recover!\n", rproc->name);
+}
+
+static void rproc_recovery_notifier(void *data, struct rproc *rproc)
+{
+	const char *recovery = rproc->recovery_disabled ? "disabled" : "enabled";
+
+	pr_info("qcom rproc: %s: recovery %s\n", rproc->name, recovery);
+
+	if (strnstr(rproc->name, "spss", strlen(rproc->name)))
+		return;
+
+	if (rproc_recovery_set_fn)
+		(rproc_recovery_set_fn)(rproc);
+}
+
+static int __init qcom_common_init(void)
+{
+	int ret = 0;
+
+	qcom_device_shutdown_in_progress = false;
+
+	sysfs_kobject = kobject_create_and_add("qcom_rproc", kernel_kobj);
+	if (!sysfs_kobject) {
+		pr_err("qcom rproc: failed to create sysfs kobject\n");
+		return -EINVAL;
+	}
+
+	ret = sysfs_create_file(sysfs_kobject, &shutdown_requested_attr.attr);
+	if (ret) {
+		pr_err("qcom rproc: failed to create sysfs file\n");
+		goto remove_kobject;
+	}
+	ret = sysfs_create_file(sysfs_kobject, &both_coredumps_attr.attr);
+	if (ret) {
+		pr_err("qcom rproc: failed to create both_coredumps sysfs file\n");
+		goto remove_shutdown_sysfs;
+	}
+
+	ret = register_trace_android_vh_rproc_recovery(qcom_check_ssr_status, NULL);
+	if (ret) {
+		pr_err("qcom rproc: failed to register trace hooks\n");
+		goto remove_coredump_sysfs;
+	}
+
+	ret = register_trace_android_vh_rproc_recovery_set(rproc_recovery_notifier, NULL);
+	if (ret) {
+		pr_err("qcom rproc: failed to register recovery_set vendor hook\n");
+		goto unregister_rproc_recovery_vh;
+	}
+
+	return 0;
+
+unregister_rproc_recovery_vh:
+	unregister_trace_android_vh_rproc_recovery(qcom_check_ssr_status, NULL);
+remove_coredump_sysfs:
+	sysfs_remove_file(sysfs_kobject, &both_coredumps_attr.attr);
+remove_shutdown_sysfs:
+	sysfs_remove_file(sysfs_kobject, &shutdown_requested_attr.attr);
+remove_kobject:
+	kobject_put(sysfs_kobject);
+	return ret;
+
+}
+module_init(qcom_common_init);
+
+static void __exit qcom_common_exit(void)
+{
+	sysfs_remove_file(sysfs_kobject, &both_coredumps_attr.attr);
+	sysfs_remove_file(sysfs_kobject, &shutdown_requested_attr.attr);
+	kobject_put(sysfs_kobject);
+	unregister_trace_android_vh_rproc_recovery(qcom_check_ssr_status, NULL);
+}
+module_exit(qcom_common_exit);
+
 MODULE_DESCRIPTION("Qualcomm Remoteproc helper driver");
 MODULE_LICENSE("GPL v2");