samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clk: axi-clkgen: Remove sometimes impossible check

Browse Source 
The size of unsigned long on 64-bit architectures is equal to the
size of u64, so this check is impossible there. This throws off
static checkers:

drivers/clk/clk-axi-clkgen.c:331 axi_clkgen_recalc_rate() warn:
impossible condition '(tmp > (~0)) => (0-u64max > u64max)'

Let's change this code to use min_t() instead so that we
get the same effect on architectures where sizeof(unsigned long)
doesn't equal sizeof(u64).

Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
This commit is contained in:
Stephen Boyd
2016-01-29 17:09:01 -08:00
parent 62d1e7823d
commit 3d6f1c7212
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/clk/clk-axi-clkgen.c
View File

@@ -328,10 +328,7 @@ static unsigned long axi_clkgen_recalc_rate(struct clk_hw *clk_hw,
tmp = (unsigned long long)(parent_rate / d) * m; tmp = (unsigned long long)(parent_rate / d) * m;
do_div(tmp, dout); do_div(tmp, dout);
if (tmp > ULONG_MAX) return min_t(unsigned long long, tmp, ULONG_MAX);
return ULONG_MAX;
return tmp;
} }
static int axi_clkgen_enable(struct clk_hw *clk_hw) static int axi_clkgen_enable(struct clk_hw *clk_hw)