samsung_sm8750/android_kernel_samsung_sm8750
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

driver: net: ethernet: mtk_star_emac: fix suspend/resume issue

Browse Source 
[ Upstream commit ba99c627aac85bc746fb4a6e2d79edb3ad100326 ]

Identify the cause of the suspend/resume hang: netif_carrier_off()
is called during link state changes and becomes stuck while
executing linkwatch_work().

To resolve this issue, call netif_device_detach() during the Ethernet
suspend process to temporarily detach the network device from the
kernel and prevent the suspend/resume hang.

Fixes: 8c7bd5a454 ("net: ethernet: mtk-star-emac: new driver")
Signed-off-by: Yanqing Wang <ot_yanqing.wang@mediatek.com>
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Signed-off-by: Biao Huang <biao.huang@mediatek.com>
Link: https://patch.msgid.link/20250528075351.593068-1-macpaul.lin@mediatek.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Yanqing Wang
2025-05-28 15:53:51 +08:00
committed by Greg Kroah-Hartman
parent acab7ca5ff
commit 2e3d96ad95
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/mediatek/mtk_star_emac.c
View File

@@ -1468,6 +1468,8 @@ static __maybe_unused int mtk_star_suspend(struct device *dev)
if (netif_running(ndev)) if (netif_running(ndev))
mtk_star_disable(ndev); mtk_star_disable(ndev);
netif_device_detach(ndev);
clk_bulk_disable_unprepare(MTK_STAR_NCLKS, priv->clks); clk_bulk_disable_unprepare(MTK_STAR_NCLKS, priv->clks);
return 0; return 0;
@@ -1492,6 +1494,8 @@ static __maybe_unused int mtk_star_resume(struct device *dev)
clk_bulk_disable_unprepare(MTK_STAR_NCLKS, priv->clks); clk_bulk_disable_unprepare(MTK_STAR_NCLKS, priv->clks);
} }
netif_device_attach(ndev);
return ret; return ret;
} }