samsung_sm8750/android_kernel_samsung_sm8750-devicetrees
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ARM: dts: qcom: remove overlay regulator node/phandle creation for sun V8

Browse Source 
Sun power grid V8 boards have seen a boot-up issue seemingly caused
by device tree overlays not being applied as expected.  This results
in the rpmh-regulator-mxlvl device not probing correctly as the
proxy-supply property isn't found/resolved.

Correct this issue by moving regulator phandle creation from V8
overlay DTs into the base DT and not creating any regulator nodes
in the overlay DTs (which are duplicates of ones in the base DT).

Change-Id: I2b3515d1ddfa4a9961ef892af61beb8e3afdfd1a
Fixes: 3e728ec361 ("ARM: dts: qcom: add PMIC device support for sun V8 power grid boards")
Signed-off-by: David Collins <quic_collinsd@quicinc.com>
This commit is contained in:
David Collins
2024-01-02 18:55:44 -08:00
parent 9fef8e1ed7
commit b994cb80a3
2 changed files with 27 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
qcom/sun-pmic-overlay-v8.dtsi
View File

@@ -1,6 +1,6 @@
// SPDX-License-Identifier: BSD-3-Clause // SPDX-License-Identifier: BSD-3-Clause
/* /*
* Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. * Copyright (c) 2023-2024 Qualcomm Innovation Center, Inc. All rights reserved.
*/ */
&VRM_S4J { &VRM_S4J {
@@ -35,32 +35,22 @@
status = "ok"; status = "ok";
}; };
&apps_rsc_drv2 { &S8F_LEVEL {
rpmh-regulator-mxlvl {
S8F_LEVEL: pm_v8f_s8_level: regulator-vdd-mxa-level {
regulator-name = "pm_v8f_s8_level"; regulator-name = "pm_v8f_s8_level";
}; };
S8F_LEVEL_AO: pm_v8f_s8_level_ao: regulator-vdd-mxa-level-ao { &S8F_LEVEL_AO {
regulator-name = "pm_v8f_s8_level_ao"; regulator-name = "pm_v8f_s8_level_ao";
}; };
};
rpmh-regulator-ldof1 { &L1F {
pm_v8f_l1: regulator-pm-vxf-l1 {
regulator-name = "pm_v8f_l1"; regulator-name = "pm_v8f_l1";
}; };
};
rpmh-regulator-ldof2 { &L2F {
pm_v8f_l2: regulator-pm-vxf-l2 {
regulator-name = "pm_v8f_l2"; regulator-name = "pm_v8f_l2";
}; };
};
rpmh-regulator-ldof3 { &L3F {
pm_v8f_l3: regulator-pm-vxf-l3 {
regulator-name = "pm_v8f_l3"; regulator-name = "pm_v8f_l3";
}; };
};
};

14
qcom/sun-regulators.dtsi
View File

@@ -1,6 +1,6 @@
// SPDX-License-Identifier: BSD-3-Clause // SPDX-License-Identifier: BSD-3-Clause
/* /*
* Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. * Copyright (c) 2023-2024 Qualcomm Innovation Center, Inc. All rights reserved.
*/ */
#include <dt-bindings/regulator/qcom,rpmh-regulator-levels.h> #include <dt-bindings/regulator/qcom,rpmh-regulator-levels.h>
@@ -65,7 +65,8 @@
proxy-supply = <&VDD_MXA_LEVEL>; proxy-supply = <&VDD_MXA_LEVEL>;
VDD_MXA_LEVEL: VDD_MX_LEVEL: S6F_LEVEL: VDD_MXA_LEVEL: VDD_MX_LEVEL: S6F_LEVEL:
pm_v6f_s6_level: regulator-vdd-mxa-level { pm_v6f_s6_level: S8F_LEVEL: pm_v8f_s8_level:
regulator-vdd-mxa-level {
regulator-name = "pm_v6f_s6_level"; regulator-name = "pm_v6f_s6_level";
qcom,set = <RPMH_REGULATOR_SET_ALL>; qcom,set = <RPMH_REGULATOR_SET_ALL>;
regulator-min-microvolt = regulator-min-microvolt =
@@ -81,7 +82,8 @@
}; };
VDD_MXA_LEVEL_AO: VDD_MX_LEVEL_AO: S6F_LEVEL_AO: VDD_MXA_LEVEL_AO: VDD_MX_LEVEL_AO: S6F_LEVEL_AO:
pm_v6f_s6_level_ao: regulator-vdd-mxa-level-ao { pm_v6f_s6_level_ao: S8F_LEVEL_AO: pm_v8f_s8_level_ao:
regulator-vdd-mxa-level-ao {
regulator-name = "pm_v6f_s6_level_ao"; regulator-name = "pm_v6f_s6_level_ao";
qcom,set = <RPMH_REGULATOR_SET_ACTIVE>; qcom,set = <RPMH_REGULATOR_SET_ACTIVE>;
regulator-min-microvolt = regulator-min-microvolt =
@@ -785,7 +787,7 @@
RPMH_REGULATOR_MODE_HPM>; RPMH_REGULATOR_MODE_HPM>;
qcom,mode-threshold-currents = <0 30000>; qcom,mode-threshold-currents = <0 30000>;
L1F: pm_v6f_l1: regulator-pm-vxf-l1 { L1F: pm_v6f_l1: pm_v8f_l1: regulator-pm-vxf-l1 {
regulator-name = "pm_v6f_l1"; regulator-name = "pm_v6f_l1";
qcom,set = <RPMH_REGULATOR_SET_ALL>; qcom,set = <RPMH_REGULATOR_SET_ALL>;
regulator-min-microvolt = <880000>; regulator-min-microvolt = <880000>;
@@ -804,7 +806,7 @@
RPMH_REGULATOR_MODE_HPM>; RPMH_REGULATOR_MODE_HPM>;
qcom,mode-threshold-currents = <0 30000>; qcom,mode-threshold-currents = <0 30000>;
L2F: pm_v6f_l2: regulator-pm-vxf-l2 { L2F: pm_v6f_l2: pm_v8f_l2: regulator-pm-vxf-l2 {
regulator-name = "pm_v6f_l2"; regulator-name = "pm_v6f_l2";
qcom,set = <RPMH_REGULATOR_SET_ALL>; qcom,set = <RPMH_REGULATOR_SET_ALL>;
regulator-min-microvolt = <1200000>; regulator-min-microvolt = <1200000>;
@@ -823,7 +825,7 @@
RPMH_REGULATOR_MODE_HPM>; RPMH_REGULATOR_MODE_HPM>;
qcom,mode-threshold-currents = <0 30000>; qcom,mode-threshold-currents = <0 30000>;
L3F: pm_v6f_l3: regulator-pm-vxf-l3 { L3F: pm_v6f_l3: pm_v8f_l3: regulator-pm-vxf-l3 {
regulator-name = "pm_v6f_l3"; regulator-name = "pm_v6f_l3";
qcom,set = <RPMH_REGULATOR_SET_ALL>; qcom,set = <RPMH_REGULATOR_SET_ALL>;
regulator-min-microvolt = <1800000>; regulator-min-microvolt = <1800000>;