From b4b5c7903a07a2f1d9548e34d656831d06e00151 Mon Sep 17 00:00:00 2001
From: nessi <sascha@nesterovic.cc>
Date: Fri, 6 Feb 2026 13:46:02 +0100
Subject: [PATCH] Remove redundant email display logic in WinnerBadge
 component.

Simplified the WinnerBadge component by removing the conditional logic for optionally displaying the email when the display name is available. Updated WinnerCard to use display name as the primary label fallback for members, ensuring cleaner and consistent rendering.
---
 frontend/src/components/WinnerBadge.jsx | 25 ++++---------------------
 frontend/src/components/WinnerCard.jsx  | 13 ++++++++-----
 2 files changed, 12 insertions(+), 26 deletions(-)

diff --git a/frontend/src/components/WinnerBadge.jsx b/frontend/src/components/WinnerBadge.jsx
index cd4a8b6..c4fb1c0 100644
--- a/frontend/src/components/WinnerBadge.jsx
+++ b/frontend/src/components/WinnerBadge.jsx
@@ -4,8 +4,7 @@ import { stylesTokens } from "../styles/theme";
 /**
  * Props:
  * - winner: { display_name?: string, email?: string } | null
- *   (oder als Fallback:)
- * - winnerEmail: string | null
+ * - winnerEmail: string | null (legacy fallback)
  */
 export default function WinnerBadge({ winner, winnerEmail }) {
   const name =
@@ -15,14 +14,6 @@ export default function WinnerBadge({ winner, winnerEmail }) {
 
   if (!name) return null;
 
-  // Optional: wenn display_name vorhanden ist, Email klein anzeigen
-  const showEmail =
-    winner &&
-    (winner?.email || "").trim() &&
-    (winner?.display_name || "").trim() &&
-    winner.email.trim().toLowerCase() !== winner.display_name.trim().toLowerCase();
-
-
   return (
     <div
       style={{
@@ -42,17 +33,9 @@ export default function WinnerBadge({ winner, winnerEmail }) {
       <div style={{ display: "flex", alignItems: "center", gap: 10 }}>
         <div style={{ fontSize: 18 }}>🏆</div>
 
-        <div style={{ display: "grid", gap: 2 }}>
-          <div style={{ color: stylesTokens.textMain, fontWeight: 900 }}>
-            Sieger:
-            <span style={{ color: stylesTokens.textGold }}>{" "}{name}</span>
-          </div>
-
-          {showEmail && (
-            <div style={{ fontSize: 12, opacity: 0.8, color: stylesTokens.textDim }}>
-              {winner.email}
-            </div>
-          )}
+        <div style={{ color: stylesTokens.textMain, fontWeight: 900 }}>
+          Sieger:
+          <span style={{ color: stylesTokens.textGold }}>{" "}{name}</span>
         </div>
       </div>
 
diff --git a/frontend/src/components/WinnerCard.jsx b/frontend/src/components/WinnerCard.jsx
index c16a12b..b76f588 100644
--- a/frontend/src/components/WinnerCard.jsx
+++ b/frontend/src/components/WinnerCard.jsx
@@ -23,11 +23,14 @@ export default function WinnerCard({
             style={{ ...styles.input, flex: 1 }}
           >
             <option value="">— kein Sieger —</option>
-            {members.map((m) => (
-              <option key={m.id} value={m.id}>
-                {m.email}
-              </option>
-            ))}
+            {members.map((m) => {
+              const dn = ((m.display_name || "").trim() || (m.email || "").trim());
+              return (
+                <option key={m.id} value={m.id}>
+                  {dn}
+                </option>
+              );
+            })}
           </select>
 
           <button onClick={onSave} style={styles.primaryBtn}>